Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workspace dependencies for parachain #2535

Merged
merged 11 commits into from
Feb 29, 2024

Conversation

Kailai-Wang
Copy link
Collaborator

Context

As topic.

It serves as a preface for the incoming polkadot dep update.

@Kailai-Wang Kailai-Wang self-assigned this Feb 28, 2024
Copy link

linear bot commented Feb 28, 2024

@Kailai-Wang Kailai-Wang requested review from a team and felixfaisal February 28, 2024 21:58
Copy link
Collaborator

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM.
Small question: when should we use std feature like this litmus-parachain-runtime = { workspace = true, features = ["std"] } ? How could we know it? Is there any other feature we need to take care?

@Kailai-Wang
Copy link
Collaborator Author

Nice. LGTM. Small question: when should we use std feature like this litmus-parachain-runtime = { workspace = true, features = ["std"] } ? How could we know it? Is there any other feature we need to take care?

You only need that for the node compilation, we know that becuase there's no default-features = false in the original toml.
I believe all necessary features are already taken care of :)

@Kailai-Wang Kailai-Wang merged commit f6a6c1e into dev Feb 29, 2024
31 of 34 checks passed
@Kailai-Wang Kailai-Wang deleted the p-551-workspace-dependencies-for-parachain branch February 29, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants