P-397 Add the new VC test case for ts-tests. #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xverin
requested review from
kziemianek,
Traf333,
BillyWooo,
grumpygreenguy and
a team
0xverin
force-pushed
the
p-328-add-new-vc-tests
branch
from
0861fad
to
6d7a943
Compare
Traf333
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Overall looks good for me. Just one question came to my mind, what are the reasons to hardcode some paths within data providers like "v1/blocks/e4068e6a326243468f35dcdc0c43f686/children". Is the e406....f686 identifier permanent, or it might change in some cases?
I think it's simply moving around the hard code place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
resolves p-397
Now all vc basic tests(e.g.
di_vc,dr_vc,ii_vctests) get data from mock service, and real data-provider tests are not included in this test.I have modified some rust code, please help to take a closer look, I hope it will not affect worker logic.