feat: test the failed parachain extrinsic handling in worker

[felixfaisal]

So the idea of this PR was:

1. Call link-identity for Bob
2. Wait for it to be succesful and capture the id-graph hash
3. Call link-identity but use a delegate signer, the extrinsic will fail since the delegate is not authorized
4. We wait, and capture the id-graph hash, no change in id-graph-hash would signify that the failed extrinsic did not execute.

[linear]

P-444 Test the failed parachain extrinsic handling in worker

[jonalvarezz]

Naïve question: why not a ts-test? i.e. when should we prefer cli test over ts-test?

[felixfaisal]

Naïve question: why not a ts-test? i.e. when should we prefer cli test over ts-test?

A good rule of thumb would be if it is assigned to rust dev, then cli would be preferred xD
However, we did have a few CI tests that make use of CLI, and have been removed, so it's not exactly reinventing the wheel since the support always has been there. This is basically my rationale.

[Kailai-Wang]

Naïve question: why not a ts-test? i.e. when should we prefer cli test over ts-test?

This is actually a good one.
I'd say either will do its job, but rust CLI generally provides more flexibility and is simpler (from code) as it's closer to call existing rust functions. So achieving the same functionality requires more code in ts :D

Upstream doesn't have ts-test btw, we need that because we want some e2e test and our F/E is ofc in ts

[Kailai-Wang]

Thanks!

While I understand what the code tries to do, I'm not sure if it meets the test goal. We want to make sure that failed extrinsics don't even get executed - imagine you transfer 1m tokens to someone and it fails as you have insufficient balance, the indirect call executor should detect that the extrinsic fails and never try to parse and execute it.

This PR tests however, when an error is thrown out during the execution of the II dispatcher, it won't write any wrong state - which is something good to test, but not the same as what we wanted to test IMO

[felixfaisal]

This PR tests however, when an error is thrown out during the execution of the II dispatcher, it won't write any wrong state - which is something good to test, but not the same as what we wanted to test IMO

I don't think so it is testing the error thrown out during the execution of the II dispatch. It is doing the former.

• So we first link-identity to Bob via the II providing the correct inputs, meaning it will not fail in II dispatch, (

  litentry-parachain/tee-worker/cli/lit_test_failed_parentchain_extrinsic.sh

  Line 47 in 94e09b2

  OUTPUT=$(${CLIENT} link-identity //Bob did:litentry:substrate:${FIRST_NEW_ACCOUNT} litentry) || { echo "Link identity command failed"; exit 1; }

  ) We check the id-graph-hash to conclude that it executed succesfully.
• We create a second link-identity however we use Eve as delegate signer -

  litentry-parachain/tee-worker/cli/lit_test_failed_parentchain_extrinsic.sh

  Line 59 in 94e09b2

  OUTPUT=$(${CLIENT} link-identity //Bob "did:litentry:substrate:${SECOND_NEW_ACCOUNT}" litentry -d //Eve) || { echo "Link identity command failed"; exit 1; }

• This extrinsic will fail on parentchain since Eve has not been set as the delegate signer for the account -

  litentry-parachain/pallets/identity-management/src/lib.rs

  Line 211 in 94e09b2

  Error::<T>::UnauthorizedUser

• We check the id-graph-hash again, no state change would mean that the above failed extrinsic did not get executed
• From the logs, it parses but it does not execute it -

  litentry-parachain/tee-worker/core/parentchain/indirect-calls-executor/src/executor.rs

  Line 190 in 94e09b2

  if let ExtrinsicStatus::Failed = xt_status {

The failed extrinsic gets parsed but is not executed, Let me know if I'm missing something here.

[kziemianek]

A more naive question: Have you considered writing unit test for it ? 😂
There is already indirect_call_can_be_added_to_pool_successfully

[Kailai-Wang]

I see, thanks. I missed the delegator on-chain logic part.

Kasper's comment makes sense too - I'm happy to have both : )