Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitacross client sample golang code #2551

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

kziemianek
Copy link
Member

Sample golang code for requesting SignEthereum direct call from bitacross worker.

@kziemianek kziemianek requested a review from a team March 5, 2024 00:12
Copy link

linear bot commented Mar 5, 2024

@kziemianek kziemianek force-pushed the p-557-write-golang-sample-client-for-bc-worker branch from d285df9 to dd6bef4 Compare March 5, 2024 00:14
Copy link
Member

@felixfaisal felixfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I was wondering if we should also verify the signature received with the public key, to make sure there are no shenanigans in the decoding

@kziemianek
Copy link
Member Author

LGTM I was wondering if we should also verify the signature received with the public key, to make sure there are no shenanigans in the decoding

This can be done later once bitacross worker exposes rpc method for retrieving public keys. In general I think it's not necessary to have such check in this example.

@felixfaisal felixfaisal enabled auto-merge (squash) March 5, 2024 07:45
@felixfaisal felixfaisal merged commit e561757 into dev Mar 5, 2024
31 checks passed
@kziemianek kziemianek deleted the p-557-write-golang-sample-client-for-bc-worker branch March 5, 2024 10:43
@Kailai-Wang
Copy link
Collaborator

A naive question: have you tried it on the actual bc-worker host (or connect to it)?

@kziemianek
Copy link
Member Author

kziemianek commented Mar 5, 2024

A naive question: have you tried it on the actual bc-worker host (or connect to it)?

No I've only tested it against bc-worker run on my host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants