-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p-569 Remove parachain events listening from ts-tests #2556
Merged
0xverin
merged 15 commits into
dev
from
p-569-remove-parachain-events-listening-from-tests
Mar 12, 2024
Merged
p-569 Remove parachain events listening from ts-tests #2556
0xverin
merged 15 commits into
dev
from
p-569-remove-parachain-events-listening-from-tests
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xverin
changed the title
p-569 Remove parachain events listening from ts-tests
[WIP]:p-569 Remove parachain events listening from ts-tests
Mar 7, 2024
If it's still WIP, you can create a |
…ttps://github.com/litentry/litentry-parachain into p-569-remove-parachain-events-listening-from-tests
0xverin
requested review from
a team,
jonalvarezz,
Kailai-Wang and
grumpygreenguy
March 11, 2024 09:20
0xverin
changed the title
[WIP]:p-569 Remove parachain events listening from ts-tests
p-569 Remove parachain events listening from ts-tests
Mar 11, 2024
jonalvarezz
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clean up!
Following this shall we remove the II interfaces too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
as the topic
this pr also deleted the ii test cases.