Prefer author_getNextNonce for nonce retrieval #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
substrate's AccountId to support other type of accounts
|
The failing tests are caused by some change in this PR. c.c @Kailai-Wang |
Kailai-Wang
changed the title
Kailai-Wang
approved these changes
Mar 15, 2024
jonalvarezz
reviewed
Mar 15, 2024
| let nonce = 0; | ||
|
|
||
| if (nonceHex) { | ||
| nonce = context.api.createType('Index', '0x' + nonceHex.slice(2)?.match(/../g)?.reverse().join('')).toNumber(); |
There was a problem hiding this comment.
hwo should we read this line:
nonceHex.slice(2)?.match(/../g)?.reverse().join('')
There was a problem hiding this comment.
I borrowed that logic from here. What this line does is to reverse the order of two character groups in the hex string while keeping the '0x' prefix. (also known as byte swapping or endian swapping).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSidechainNonceindi-utils.tsto retrieve the nonce usingauthor_getNextNonceRPC call and updated the corresponding tests.author_getNextNonceto expectIdentityto support other type of accounts.