Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handshaking between workers for local setup #2589

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

Traf333
Copy link
Contributor

@Traf333 Traf333 commented Mar 18, 2024

Context

this PR fixes couple of minor issues for multiworker setup in local environment

  1. error: Found argument '--request-state' which wasn't expected, or isn't valid in this context
[Sidechain] imported block (number: 306, tcalls: 0, author: 0x26491bbf431770cc4b0b23aad6f1216a40c97c098600d981a022d9c246409cad), based on parentchain block 751
[2024-03-18T14:01:54.020389Z ERROR itc_peer_top_broadcaster] Could not connect to peer wss://127.0.0.1:2100, reason: "Could not open websocket connection: HandshakeError::Failure(Tls(Dns(InvalidDNSNameError)))"

Copy link

linear bot commented Mar 18, 2024

Copy link
Collaborator

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the fix to something.
I think --request-state flag is still valid.

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - request-state was indeed removed earlier (cc @BillyWooo)

@Traf333 Traf333 merged commit be60435 into dev Mar 18, 2024
26 checks passed
@Traf333 Traf333 deleted the p-636-handshaking-between-worker-for-local-setup branch March 18, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants