Compiling non-prod code only when explicitly specified #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silva-fj
commented
Mar 20, 2024
…t-because-production
…t-because-production
Kailai-Wang
approved these changes
Mar 22, 2024
…t-because-production
silva-fj
deleted the
p-462-non-prod-code-unsafe-compiled-by-default-because-production
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including dev only code when the
productionfeature is not enabled makes it posible to include unsafe code to the production build in the cases where the feature has not been properly propagated. These changes switch the logic to include prod code by default and only include dev code when explicitly specified.