Register the enclave only once #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfaisal
reviewed
Mar 26, 2024
kziemianek
reviewed
Apr 5, 2024
Kailai-Wang
reviewed
Apr 8, 2024
…vious implementation
Kailai-Wang
approved these changes
Apr 8, 2024
silva-fj
deleted the
p-630-only-register-enclave-once-for-non-primary-workers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the logic:
primary_enclave_identifier_for_shardreturnsNoneif there is no worker registered for the shard.In the case it's
Some, it means there is a primary worker registered for the shard, we are a non-primary worker if it is first run so we need to request provisioning. Then in any case we register worker.In case it's
None, it means there is no primary worker registered for the shard, then we are the primary worker