Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: P-654 added solana signature check #2635

Merged
merged 6 commits into from
Apr 11, 2024

Conversation

higherordertech
Copy link
Contributor

Context

as titles

Labels

Please apply following PR-related labels when appropriate:

  • C0-breaking: if your change could break the existing client, e.g. API change, critical logic change
  • C1-noteworthy: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvement

How (Optional)

Testing Evidences

Please attach any relevant evidences if applicable

Tested via unit test

Copy link

linear bot commented Apr 2, 2024

Copy link
Contributor

@silva-fj silva-fj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a place where we put shared/common code between workers? if not, what's the reason?

@BillyWooo
Copy link
Collaborator

Do we have a place where we put shared/common code between workers? if not, what's the reason?

This is under discussion. Check issue P-600 and related ones.

@BillyWooo
Copy link
Collaborator

The changes looks good to me. Can you take a look at the CI test failure of one worker?

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we have ts-test for it (at least happy path)?

@higherordertech higherordertech enabled auto-merge (squash) April 8, 2024 09:55
@higherordertech higherordertech force-pushed the P-654-fix-missing-check-solana branch 2 times, most recently from ed6caa8 to b2a75c3 Compare April 11, 2024 04:46
@higherordertech
Copy link
Contributor Author

Shall we have ts-test for it (at least happy path)?

Yes integration tests have been added too.

@Kailai-Wang
Copy link
Collaborator

Shall we have ts-test for it (at least happy path)?

Yes integration tests have been added too.

I'm not sure if the test is run in CI though

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@higherordertech higherordertech merged commit d3e0f30 into dev Apr 11, 2024
30 checks passed
@Kailai-Wang Kailai-Wang deleted the P-654-fix-missing-check-solana branch April 11, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants