Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing init_shard_config #2648

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

silva-fj
Copy link
Contributor

This is used upstream to update a shard registry (on-chain) storage with the configs of shards on the parentchain. We don't have this in our parachain.

Copy link

linear bot commented Apr 10, 2024

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side

@@ -91,7 +91,6 @@ webpki = { git = "https://github.com/mesalock-linux/webpki", branch = "mesalock_
base58 = { rev = "sgx_1.1.3", package = "rust-base58", default-features = false, features = ["mesalock_sgx"], git = "https://github.com/mesalock-linux/rust-base58-sgx" }

cid = { default-features = false, git = "https://github.com/whalelephant/rust-cid", branch = "nstd" }
enclave-bridge-primitives = { default-features = false, git = "https://github.com/integritee-network/pallets.git", branch = "sdk-v0.12.11-polkadot-v0.9.42" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch :)

@silva-fj silva-fj merged commit a6f65b3 into dev Apr 10, 2024
26 checks passed
@silva-fj silva-fj deleted the p-627-review-the-need-of-init_shard_config branch April 10, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants