Hotfix BRC20 assertion contents when data is empty #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouhuitian
added
the
C0-breaking
jonalvarezz
approved these changes
Apr 10, 2024
Comment on lines
29
to
30
| // Keep all name in lowercase here by purpose | ||
| const BRC20_TOKENS: [&str; 7] = ["ordi", "sats", "rats", "mmss", "long", "cats", "btcs"]; | ||
| const BRC20_TOKENS: [&str; 7] = ["ordi", "sats", "rats", "MMSS", "long", "cats", "BTCs"]; |
There was a problem hiding this comment.
should we remove the comment on line 29 or are we missing something?
|
|
||
| response_items | ||
| .iter() | ||
| .filter(|&item| BRC20_TOKENS.contains(&item.tick.as_str())) |
There was a problem hiding this comment.
should we compare using lowercases to forget about it? e.g., data provider changes the case for cats -> CATs
BillyWooo
reviewed
Apr 10, 2024
| @@ -72,30 +79,60 @@ pub trait BRC20AmountHolderCredential { | |||
|
|
|||
| impl BRC20AmountHolderCredential for Credential { | |||
| fn update_brc20_amount_holder_credential(&mut self, response_items: &[ResponseItem]) { | |||
| for item in response_items { | |||
| if BRC20_TOKENS.contains(&item.tick.to_lowercase().as_str()) { | |||
There was a problem hiding this comment.
should we keep to_lowercase() for simplicity? then the above BRC20_TOEKN doesn't need to change.
zhouhuitian
removed
the
C0-breaking
|
Ok, keep |
zhouhuitian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the case of an empty response, there are two modifications:
["ordi", "sats", "rats", "MMSS", "long", "cats", "BTCs"], with all balances set to 0.0. The effect is as shown below.{ "assertions": [ { "and": [ { "src": "$token", "op": "==", "dst": "$ordi" }, { "src": "$holding_amount", "op": ">=", "dst": "0" }, { "src": "$holding_amount", "op": "<", "dst": "1" } ] }, { "and": [ { "src": "$token", "op": "==", "dst": "$sats" }, { "src": "$holding_amount", "op": ">=", "dst": "0" }, { "src": "$holding_amount", "op": "<", "dst": "40000000" } ] }, { "and": [ { "src": "$token", "op": "==", "dst": "$rats" }, { "src": "$holding_amount", "op": ">=", "dst": "0" }, { "src": "$holding_amount", "op": "<", "dst": "40000" } ] }, { "and": [ { "src": "$token", "op": "==", "dst": "$MMSS" }, { "src": "$holding_amount", "op": ">=", "dst": "0" }, { "src": "$holding_amount", "op": "<", "dst": "20" } ] }, { "and": [ { "src": "$token", "op": "==", "dst": "$long" }, { "src": "$holding_amount", "op": ">=", "dst": "0" }, { "src": "$holding_amount", "op": "<", "dst": "20" } ] }, { "and": [ { "src": "$token", "op": "==", "dst": "$cats" }, { "src": "$holding_amount", "op": ">=", "dst": "0" }, { "src": "$holding_amount", "op": "<", "dst": "10000" } ] }, { "and": [ { "src": "$token", "op": "==", "dst": "$BTCs" }, { "src": "$holding_amount", "op": ">=", "dst": "0" }, { "src": "$holding_amount", "op": "<", "dst": "5" } ] } ] }true, because regardless of the balance amount, it will always fall within a certain range.