remove unwrap from VcRequestSender
#2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kziemianek
added
D2-bug
|
The fix looks fine to me. But what do you think to revisit the structure/working flow of threads/initialization steps? I think it's better to eliminate it by design. |
The issue has Urgent priority and S estimation so I believe we aim here only I think we can try to improve the design and avoid using globals - this should be addressed separately. |
BillyWooo
approved these changes
Apr 25, 2024
BillyWooo
deleted the
p-703-race-condition-in-global-component-initialisation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents from panics if sender is not yet initialized and vc requests are consumed.