-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: P-584 added bitcoin holding amount VC #2689
Conversation
d96cdf1
to
e414b45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible and worthy to have ts test for this ?
Not sure if |
tee-worker/litentry/core/service/src/web3_token/token_balance/btc_balance.rs
Outdated
Show resolved
Hide resolved
e414b45
to
4829aed
Compare
…new ts-tests for it with bumped vc-jsonschema version
3254468
to
2556fd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Context
Added new data provider for BTC from https://blockchain.info, as this data is not available from existing dp.
Labels
Please apply following PR-related labels when appropriate:
C0-breaking
: if your change could break the existing client, e.g. API change, critical logic changeC1-noteworthy
: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvementHow (Optional)
Testing Evidences
Please attach any relevant evidences if applicable
Generated VC example: