Adding support for discord oauth verification #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silva-fj
added
the
C0-breaking
kziemianek
approved these changes
May 9, 2024
tee-worker/client-api/parachain-api/prepare-build/interfaces/identity/definitions.ts
Show resolved
Hide resolved
tee-worker/ts-tests/integration-tests/common/utils/identity-helper.ts
Outdated
Show resolved
Hide resolved
BillyWooo
approved these changes
May 9, 2024
We need to setup OAuth2 on the app we use or create a new app in the account and set it up to get the client id and client secret. |
Kailai-Wang
reviewed
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new option to verify discord accounts using OAuth2.0
The discord oauth 2.0 mechanism works a little differently than Twitter's, there is no need to generate a code challenge from our side so clients only need one interaction with the worker to link identities.
Just like with twitter, we need to register the redirect uri clients will use in the discord developer account.
As Kai suggested here #2641 (review), in the future, we could register these oauth clients in the parachain.
Important
DISCORD_CLIENT_IDandDISCORD_CLIENT_SECRET.https://discord.com/oauth2/authorize?client_id={DISCORD_CLIENT_ID}&response_type=code&redirect_uri={CLIENTS-REDIRECT-URI}&scope=identify.