-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Intel SDK 2.21 against rust-sdk v2.0.0 #2813
Merged
Kailai-Wang
merged 21 commits into
p-430-try-out-rust-sgx-sdk-200-branch
from
p-668-upgrade-the-supported-intel-sdk-to-219
Jun 18, 2024
Merged
Support Intel SDK 2.21 against rust-sdk v2.0.0 #2813
Kailai-Wang
merged 21 commits into
p-430-try-out-rust-sgx-sdk-200-branch
from
p-668-upgrade-the-supported-intel-sdk-to-219
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de-the-supported-intel-sdk-to-219
…de-the-supported-intel-sdk-to-219
…de-the-supported-intel-sdk-to-219
…de-the-supported-intel-sdk-to-219
…de-the-supported-intel-sdk-to-219
…de-the-supported-intel-sdk-to-219
silva-fj
approved these changes
Jun 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BillyWooo
approved these changes
Jun 17, 2024
787502c
into
p-430-try-out-rust-sgx-sdk-200-branch
31 of 33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The target branch of this PR is
p-430-try-out-rust-sgx-sdk-200-branch
, notdev
.CI run: https://github.com/litentry/litentry-parachain/actions/runs/9526558116
Rust SDK revision: https://github.com/Kailai-Wang/incubator-teaclave-sgx-sdk/tree/v2.0.0-sdk-2.21, it is based on https://gitlab.com/dexlabs/incubator-teaclave-sgx-sdk/-/tree/v2.0.0-sgx-emm?ref_type=heads
Tested on a newly installed ubuntu 22 with Intel SDK 2.21, both HW and SW mode.
Notes
sgx_crypto
has some problems underucrypto
feature, so that the RsaKeyPair creation/de-/encryption will panic for untrusted (non-enclave) part, the trusted part looks good though.Thus this PR tries to use a
lc-rsa-wrapper
crate to callrsa
crate under the hood. It's mainly used in unit-tests and CLIEdit:
It seems having 960 threads in vc-task-handler why keeping TCSNum = 256 still works (= compiles and runs), I don't know the exact performance penalty though.. I guess we'll need a follow-up issue for that
From ChatGPT: