P-906 fix: update limit param to 100 for the geniidata API for BRC20 VC #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kailai-Wang
reviewed
Jun 29, 2024
| @@ -68,8 +68,8 @@ impl RestPath<String> for GeniidataResponse { | |||
| } | |||
| } | |||
|
|
|||
| // According to https://geniidata.readme.io/reference/get-brc20-tick-list-copy, the maximum limit is i32::MAX | |||
| const GENIIDATA_QUERY_LIMIT: &str = "2147483647"; | |||
| // According to https://geniidata.readme.io/reference/get-brc20-tick-list-copy, the maximum limit is 100 | |||
There was a problem hiding this comment.
Hmm I don't see the limit is 100 tho, the doc only says i32
There was a problem hiding this comment.
Yeah, that's exactly the problem. What their doc says is not their runtime response allowed, see:
There was a problem hiding this comment.
So as per my understanding it's our limit in order to do paged query
added 2 commits
July 1, 2024 12:52
… change it to pagination query
…ck server to return empty response while offset param is not 0
higherordertech
force-pushed
the
hotfix-BRC20
branch
from
0bc9e74
to
0f9f8b2
Compare
…et param is not 0 or empty
Kailai-Wang
approved these changes
Jul 1, 2024
BillyWooo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and change it to pagination query
Context
hotfix geniidata api breaking changes
Labels
Please apply following PR-related labels when appropriate:
C0-breaking: if your change could break the existing client, e.g. API change, critical logic changeC1-noteworthy: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvementHow (Optional)
Testing Evidences
Please attach any relevant evidences if applicable