Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust runtime governance config #681

Merged
merged 11 commits into from
Jul 5, 2022
Merged

Conversation

Kailai-Wang
Copy link
Collaborator

resolves #667

@Kailai-Wang Kailai-Wang requested a review from a team July 4, 2022 06:43
@Kailai-Wang Kailai-Wang self-assigned this Jul 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #681 (09720ac) into dev (b6c37d1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #681   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files          12       12           
  Lines        1683     1683           
=======================================
  Hits         1615     1615           
  Misses         68       68           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6c37d1...09720ac. Read the comment docs.

runtime/common/src/lib.rs Show resolved Hide resolved
runtime/litentry/src/lib.rs Show resolved Hide resolved
@wangminqi
Copy link
Member

I see quite a lot of changes on non-democracy parts from "EnsureRoot" into "EnsureRootOr***". I am wondering if we should keep it the old way. I feel some of them should be just triggered by democracy root, or we prefer to maintain some special power around?

@Kailai-Wang
Copy link
Collaborator Author

I see quite a lot of changes on non-democracy parts from "EnsureRoot" into "EnsureRootOr***". I am wondering if we should keep it the old way. I feel some of them should be just triggered by democracy root, or we prefer to maintain some special power around?

The problem is if we want those actions only to be triggered by a referrenda, as it's the only way to dispatch the call as Root later. Involving Council is more efficient but less decentralised. Teams like phala almost use RootOrHalfCouncil all over the place.

@wangminqi
Copy link
Member

I see quite a lot of changes on non-democracy parts from "EnsureRoot" into "EnsureRootOr***". I am wondering if we should keep it the old way. I feel some of them should be just triggered by democracy root, or we prefer to maintain some special power around?

The problem is if we want those actions only to be triggered by a referrenda, as it's the only way to dispatch the call as Root later. Involving Council is more efficient but less decentralised. Teams like phala almost use RootOrHalfCouncil all over the place.

Got it.

@Kailai-Wang
Copy link
Collaborator Author

Kailai-Wang commented Jul 4, 2022

I see quite a lot of changes on non-democracy parts from "EnsureRoot" into "EnsureRootOr***". I am wondering if we should keep it the old way. I feel some of them should be just triggered by democracy root, or we prefer to maintain some special power around?

The problem is if we want those actions only to be triggered by a referrenda, as it's the only way to dispatch the call as Root later. Involving Council is more efficient but less decentralised. Teams like phala almost use RootOrHalfCouncil all over the place.

Got it.

The only two EnsureRoot<> left are:

  • BlacklistOrigin in democracy
  • ManagerOrigin in preimage

I refer other other teams' implementation to eventually decide to retain them. Plus those two are rarely used.

runtime/litentry/src/lib.rs Outdated Show resolved Hide resolved
runtime/litentry/src/lib.rs Outdated Show resolved Hide resolved
runtime/litentry/src/lib.rs Outdated Show resolved Hide resolved
runtime/litentry/src/lib.rs Show resolved Hide resolved
runtime/litentry/src/lib.rs Outdated Show resolved Hide resolved
@Kailai-Wang Kailai-Wang merged commit 188bd85 into dev Jul 5, 2022
@Kailai-Wang Kailai-Wang deleted the 667-adjust-governance-config branch July 5, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double-check the runtime parameters and configuration
3 participants