Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions in documentation for packet decoding in Wireshark #185

Closed
mickel8 opened this issue Oct 24, 2020 · 2 comments
Closed

Instructions in documentation for packet decoding in Wireshark #185

mickel8 opened this issue Oct 24, 2020 · 2 comments

Comments

@mickel8
Copy link
Contributor

mickel8 commented Oct 24, 2020

Hi,
what do you think about providing more information about how to set up packet decoding in Wireshark in Key logging and Wireshark section in documentation?

I am testing examples and I had to remove QUIC prefix in file containing key logs and set this file in TLS (Pre)-Master-Secret log in Wireshark. There is also a nice table with infomration which version of Wireshark supports which QUIC draft. (link)
It would be really nice to include the above in documentation. If you think it's a good idea I can make a PR.

@dtikhonov
Copy link
Contributor

Thanks for pointing it out, we'll fix the example programs.

Where would you recommend we place the documentation? (Also, we take PRs!)

litespeedtech pushed a commit that referenced this issue Oct 28, 2020
- [FEATURE] QUIC and HTTP/3 Internet Draft 31 support.  Drop ID-30
  and ID-31 support.
- [BUGFIX] Divide-by-zero in newly enabled conn stats code when no
  packets were sent.
- [BUGFIX] Memory leak in gQUIC client when server hello cannot be
  parsed.
- [BUGFIX] Server Initial packet size calculation.
- Log user-agent and CONN_CLOSE reason when peer reports error.
- Example programs: Specify ALPN for echo and md5 clients and servers
  (issue #184).
- Example programs: Don't add "QUIC_" prefix to lines in keylog file
  (issue #185).
- http_server: Fix fd leak in preadv mode; fix preadv() usage when
  reading from disk.
@litespeedtech
Copy link
Owner

Fixed in 2.24.0 -- closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants