Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redis container and support database deletion #68

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

travistran1989
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Code-Egg Code-Egg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @travistran1989

For the delete database option, it seems like the domain is not required, can we remove line 185, and update the help message according to it?

For the Redis part, should we open 6379 ports? May I know what value we should put into the WordPress Plugin to connect to the service?

@travistran1989
Copy link
Contributor Author

travistran1989 commented Dec 27, 2023 via email

@Code-Egg
Copy link
Collaborator

I just did a quick test, and it seems that inputting the redis to the field would make it work, no port open is needed.
redis

@travistran1989
Copy link
Contributor Author

travistran1989 commented Dec 28, 2023 via email

@Code-Egg Code-Egg merged commit 3ee0c98 into litespeedtech:master Jan 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants