Skip to content

Commit

Permalink
fix: correct bucket name (#184)
Browse files Browse the repository at this point in the history
* fix: correct bucket name

* chore: oops

* fix: make upload coverage execute before sonar

* feat: revert order change

* feat: adjust coverage config

* chore: i don't think we need to do this now.
  • Loading branch information
cofin committed May 3, 2024
1 parent 6558ad8 commit bd2d973
Showing 1 changed file with 31 additions and 29 deletions.
60 changes: 31 additions & 29 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -126,32 +126,34 @@ jobs:
docs/_build/html
.pr_number
upload-test-coverage:
runs-on: ubuntu-latest
needs:
- test
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: "3.12"

- name: Download Artifacts
uses: actions/download-artifact@v4
with:
name: coverage-xml

- name: Combine coverage files
run: |
python -Im pip install coverage covdefaults
python -Im coverage combine
python -Im coverage xml -i
- name: Fix coverage file name
run: sed -i "s/home\/runner\/work\/advanced-alchemy\/advanced-alchemy/github\/workspace/g" coverage.xml

- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v4
with:
files: coverage.xml
token: ${{ secrets.CODECOV_TOKEN }}
# upload-test-coverage:
# runs-on: ubuntu-latest
# needs:
# - test
# steps:
# - uses: actions/checkout@v4
# - uses: actions/setup-python@v5
# with:
# python-version: "3.12"

# - name: Download Artifacts
# uses: actions/download-artifact@v4
# with:
# name: coverage-xml
# path: coverage.xml
# merge-multiple: true

# - name: Combine coverage files
# run: |
# python -Im pip install coverage covdefaults
# python -Im coverage combine
# python -Im coverage xml -i

# - name: Fix coverage file name
# run: sed -i "s/home\/runner\/work\/advanced-alchemy\/advanced-alchemy/github\/workspace/g" coverage.xml

# - name: Upload coverage reports to Codecov
# uses: codecov/codecov-action@v4
# with:
# files: coverage.xml
# token: ${{ secrets.CODECOV_TOKEN }}

0 comments on commit bd2d973

Please sign in to comment.