Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge table argument helper #158

Merged
merged 6 commits into from
Apr 10, 2024
Merged

feat: merge table argument helper #158

merged 6 commits into from
Apr 10, 2024

Conversation

cofin
Copy link
Member

@cofin cofin commented Apr 10, 2024

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

When using mixins that include their own tablerags, it is difficult to append info into the model such as a comment.

This PR adds a helper function to merge the args together.

Close Issue(s)

@cofin cofin requested review from a team as code owners April 10, 2024 16:25
advanced_alchemy/base.py Outdated Show resolved Hide resolved
advanced_alchemy/base.py Outdated Show resolved Hide resolved
advanced_alchemy/base.py Outdated Show resolved Hide resolved
advanced_alchemy/base.py Outdated Show resolved Hide resolved
cofin and others added 4 commits April 10, 2024 14:01
Co-authored-by: Peter Schutt <peter.github@proton.me>
Co-authored-by: Peter Schutt <peter.github@proton.me>
Co-authored-by: Peter Schutt <peter.github@proton.me>
Co-authored-by: Peter Schutt <peter.github@proton.me>
Copy link

sonarcloud bot commented Apr 10, 2024

Copy link

Documentation preview will be available shortly at https://jolt-org.github.io/advanced-alchemy-docs-preview/158

@cofin cofin merged commit 99c5446 into main Apr 10, 2024
12 checks passed
@cofin cofin deleted the merge-table-args branch April 10, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants