Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: use __bases__ to merge mixin table args #194

Merged
merged 4 commits into from
May 22, 2024
Merged

Conversation

peterschutt
Copy link
Contributor

@peterschutt peterschutt commented May 15, 2024

Description

Uses __bases__ of the DeclaredAttr type to get __table_args__ of classes in the mixin hierarchy.

Closes

@peterschutt peterschutt requested review from a team as code owners May 15, 2024 20:30
Uses MRO of the DeclaredAttr type to get `__table_args__` of classes in the mixin hierarchy.
@peterschutt peterschutt changed the title refactor!: use mro to merge mixin table args refactor!: use __bases__ to merge mixin table args May 16, 2024
Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Cody Fincher <204685+cofin@users.noreply.github.com>
Copy link

sonarcloud bot commented May 22, 2024

Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/advanced-alchemy-docs-preview/194

@cofin cofin merged commit 8c8dec7 into main May 22, 2024
13 checks passed
@cofin cofin deleted the merge-table-args branch May 22, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants