Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove event_loop fixture #135

Merged
merged 1 commit into from
Mar 13, 2024
Merged

test: remove event_loop fixture #135

merged 1 commit into from
Mar 13, 2024

Conversation

peterschutt
Copy link
Contributor

I think this is just an artefact of having used pytest-asyncio in the past.

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

Close Issue(s)

I think this is just an artefact of having used pytest-asyncio in the past.
@peterschutt peterschutt requested review from cofin and a team as code owners March 13, 2024 00:45
Copy link

railway-app bot commented Mar 13, 2024

This PR was not deployed automatically as @peterschutt does not have access to the Railway project.

In order to get automatic PR deploys, please add @peterschutt to the project inside the project settings page.

Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it LGTM!

@cofin cofin enabled auto-merge (squash) March 13, 2024 00:49
@cofin cofin disabled auto-merge March 13, 2024 02:53
@cofin cofin merged commit b5b90ec into main Mar 13, 2024
8 checks passed
@cofin cofin deleted the remove-event-loop-fixture branch March 13, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants