Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: signature for _sqla_on_begin method #140

Merged
merged 1 commit into from
Mar 23, 2024
Merged

fix: signature for _sqla_on_begin method #140

merged 1 commit into from
Mar 23, 2024

Conversation

sorasful
Copy link
Contributor

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • [ X] Pre-Commit Checks were ran and passed
  • [X ] Tests were ran and passed

Description

Signature of one of the _sqla_on_begin method is invalid.

Close Issue(s)

Fixes #139

@sorasful sorasful requested review from cofin and a team as code owners March 23, 2024 12:15
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sorasful sorasful changed the title Fix signature for _sqla_on_begin method fix: signature for _sqla_on_begin method Mar 23, 2024
cofin
cofin approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@cofin cofin merged commit 5cbc78a into litestar-org:main Mar 23, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofin cofin cofin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: app database upgrade command not working
2 participants
@sorasful @cofin