Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use to_dict method instead of __dict__ for UserUpdate #142

Merged
merged 2 commits into from
Mar 23, 2024
Merged

fix: Use to_dict method instead of __dict__ for UserUpdate #142

merged 2 commits into from
Mar 23, 2024

Conversation

sorasful
Copy link
Contributor

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • [ X] Pre-Commit Checks were ran and passed
  • [ X] Tests were ran and passed

Description

Fix app users promote-to-superuser command not working because of use of __dict__ instead of to_dict() method.

Close Issue(s)

Fixes #141

@sorasful sorasful requested review from cofin and a team as code owners March 23, 2024 13:10
@sorasful sorasful changed the title Fix: Use to_dict method instead of __dict__ for UserUpdate fix: Use to_dict method instead of __dict__ for UserUpdate Mar 23, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cofin cofin merged commit 227792d into litestar-org:main Mar 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofin cofin cofin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: app users promote-to-superuser command not working
2 participants
@sorasful @cofin