Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade(WIP): litestar2.0 , #287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

v3ss0n
Copy link
Contributor

@v3ss0n v3ss0n commented Sep 6, 2023

… yaml to 5.3.1 to make poetry happy

Pull Request Checklist

  • New code has 100% test coverage
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

  • upgrade: litestar 2.0
  • upgrade: pydantic 2.2
  • downgrade: pyyaml:5.3.1
  • refactor: lib's dependencies and service , replaced with @cofin 's fullstack.
  • upgrade: settings to pydantic 2.x using pydantic-settings

Close Issue(s)

@mbeijen
Copy link

mbeijen commented Oct 27, 2023

Hi, I ran into issues with Poetry, which would be fixed by this PR. However the PR is failing I guess because you did not install and run pre-commit?
Can you maybe change that so this can get merged? If you have no interest or time anymore I can also do that, just let me know

@v3ss0n
Copy link
Contributor Author

v3ss0n commented Oct 27, 2023

I am not sure decision on this,

We have a much full featured litestar-fullstack now . @peterschutt what do you think about this repo , will this be archived?

@JacobCoffee
Copy link
Member

@peterschutt what do you think of this or this repo in general? plans to slim it down or?

@JacobCoffee
Copy link
Member

it'd be cool to use our docker hosting we got sponsored from Docker to host free images

@peterschutt
Copy link
Contributor

peterschutt commented Nov 29, 2023

This was the last conversation about this repo that I'm aware of: https://discord.com/channels/919193495116337154/1154552571025956985/1154552571025956985

From that discussion it seems as though there is a place for an example that doesn't require the cognitive load that fullstack requires to get around it.

Whatever the future holds, this repo needs love and leaving it "unmaintained" doesn't do us any favors. We should probably make it private for the time being and assess.

@darinkishore
Copy link

This was the last conversation about this repo that I'm aware of: https://discord.com/channels/919193495116337154/1154552571025956985/1154552571025956985

From that discussion it seems as though there is a place for an example that doesn't require the cognitive load that fullstack requires to get around it.

Whatever the future holds, this repo needs love and leaving it "unmaintained" doesn't do us any favors. We should probably make it private for the time being and assess.

Just a quick bit of feedback, I started trying to implement litestar instead of flask, got like 3 hours into implementing the things from the fullstack repo, couldn't take the cognitive load, and decided to not go with litestar ATM (probably going to try again later, also have django background!)

this repo DEFINITELY has a place, a simple working example with the basics (ie: SQLAlchemy, maybe non-class based controllers, etc..) would be amazing for getting people onboarded a lot quicker. with django, you can set it up and start working and it doesn't feel like there's a whole lot to do to start productionizing, but here, it felt really overwhelming! just a little bit of feedback, hope provides some perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants