Bug: TypeError: parse_url_encoded_dict() got some positional-only arguments passed as keyword arguments: 'qs' and 'parse_numbers'

[euri10]

Description

New litestar install

❯ poetry add git+https://github.com/litestar-org/litestar.git

Updating dependencies
Resolving dependencies... (1.2s)

Package operations: 7 installs, 0 updates, 0 removals

  • Installing python-dateutil (2.8.2)
  • Installing faker (19.1.0)
  • Installing fast-query-parsers (1.0.1)
  • Installing msgspec (0.17.0)
  • Installing multidict (6.0.4)
  • Installing polyfactory (2.6.2)
  • Installing litestar (2.0.0beta2 dc8790e)

leads to this error filling the form below:

Traceback (most recent call last):
  File "/home/lotso/.cache/pypoetry/virtualenvs/abdul-5gvWwsxX-py3.11/lib/python3.11/site-packages/litestar/middleware/exceptions/middleware.py", line 157, in __call__
    await self.app(scope, receive, send)
  File "/home/lotso/.cache/pypoetry/virtualenvs/abdul-5gvWwsxX-py3.11/lib/python3.11/site-packages/litestar/routes/http.py", line 77, in handle
    response = await self._get_response_for_request(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/lotso/.cache/pypoetry/virtualenvs/abdul-5gvWwsxX-py3.11/lib/python3.11/site-packages/litestar/routes/http.py", line 129, in _get_response_for_request
    response = await self._call_handler_function(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/lotso/.cache/pypoetry/virtualenvs/abdul-5gvWwsxX-py3.11/lib/python3.11/site-packages/litestar/routes/http.py", line 158, in _call_handler_function
    response_data, cleanup_group = await self._get_response_data(
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/lotso/.cache/pypoetry/virtualenvs/abdul-5gvWwsxX-py3.11/lib/python3.11/site-packages/litestar/routes/http.py", line 182, in _get_response_data
    kwargs["data"] = await kwargs["data"]
                     ^^^^^^^^^^^^^^^^^^^^
  File "/home/lotso/.cache/pypoetry/virtualenvs/abdul-5gvWwsxX-py3.11/lib/python3.11/site-packages/litestar/_kwargs/extractors.py", line 363, in extract_url_encoded_extractor
    else parse_url_encoded_form_data(await connection.body())
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/lotso/.cache/pypoetry/virtualenvs/abdul-5gvWwsxX-py3.11/lib/python3.11/site-packages/litestar/_parsers.py", line 24, in parse_url_encoded_form_data
    return parse_url_encoded_dict(qs=encoded_data, parse_numbers=False)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: parse_url_encoded_dict() got some positional-only arguments passed as keyword arguments: 'qs' and 'parse_numbers'
Traceback (most recent call last):
  File "/home/lotso/.cache/pypoetry/virtualenvs/abdul-5gvWwsxX-py3.11/lib/python3.11/site-packages/litestar/middleware/exceptions/middleware.py", line 157, in __call__
    await self.app(scope, receive, send)
  File "/home/lotso/.cache/pypoetry/virtualenvs/abdul-5gvWwsxX-py3.11/lib/python3.11/site-packages/litestar/routes/http.py", line 77, in handle
    response = await self._get_response_for_request(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/lotso/.cache/pypoetry/virtualenvs/abdul-5gvWwsxX-py3.11/lib/python3.11/site-packages/litestar/routes/http.py", line 129, in _get_response_for_request
    response = await self._call_handler_function(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/lotso/.cache/pypoetry/virtualenvs/abdul-5gvWwsxX-py3.11/lib/python3.11/site-packages/litestar/routes/http.py", line 158, in _call_handler_function
    response_data, cleanup_group = await self._get_response_data(
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/lotso/.cache/pypoetry/virtualenvs/abdul-5gvWwsxX-py3.11/lib/python3.11/site-packages/litestar/routes/http.py", line 182, in _get_response_data
    kwargs["data"] = await kwargs["data"]
                     ^^^^^^^^^^^^^^^^^^^^
  File "/home/lotso/.cache/pypoetry/virtualenvs/abdul-5gvWwsxX-py3.11/lib/python3.11/site-packages/litestar/_kwargs/extractors.py", line 363, in extract_url_encoded_extractor
    else parse_url_encoded_form_data(await connection.body())
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/lotso/.cache/pypoetry/virtualenvs/abdul-5gvWwsxX-py3.11/lib/python3.11/site-packages/litestar/_parsers.py", line 24, in parse_url_encoded_form_data
    return parse_url_encoded_dict(qs=encoded_data, parse_numbers=False)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: parse_url_encoded_dict() got some positional-only arguments passed as keyword arguments: 'qs' and 'parse_numbers'
INFO:     127.0.0.1:51104 - "POST /auth/login HTTP/1.1" 500 Internal Server Error

URL to code causing the issue

No response

MCVE

@dataclass
class LoginFormData:
    username: str
    password: str
    captcha: str


@post("/login", name="login_post")
async def login_post(
    request: Request,
    conn: BuildPgConnection,
    app_settings: AppSettings,
    data: Annotated[LoginFormData, Body(media_type=RequestEncodingType.URL_ENCODED)],
) -> Template:
    try:

Steps to reproduce

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Screenshots

"![SCREENSHOT_DESCRIPTION](SCREENSHOT_LINK.png)"

Logs

No response

Litestar Version

• Installing litestar (2.0.0beta2 dc8790e)

Platform

• Linux
• Mac
• Windows
• Other (Please specify in the description above)

Funding

• If you would like to see an issue prioritized, make a pledge towards it!
• We receive the pledge once the issue is completed & verified

[provinzkraut]

I believe this is related to a recent change in fast-query-parsers. @Goldziher?

Not sure why this hasn't been caught in our tests though.

[Goldziher]

Hmm yes, seems that maturin is positional only.

Can you remove parse_numbers= and keep the args?

[provinzkraut]

Hmm yes, seems that maturin is positional only.

It does support it. I have a fix read to go for fast-query-parsers. PR incoming.

[provinzkraut]

This should resolve it: litestar-org/fast-query-parsers#18 by allowing positional as well as keyword arguments.