Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make positional only args kwargs or positional #18

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

provinzkraut
Copy link
Member

Makes the positional only args of parse_query_string and parse_url_encoded_dict positional or keyword args.

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description

Close Issue(s)

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@provinzkraut provinzkraut merged commit f6bd946 into main Jul 20, 2023
10 checks passed
@provinzkraut provinzkraut deleted the fix-pos-only-args branch July 20, 2023 12:40
@euri10
Copy link

euri10 commented Jul 20, 2023

seems like the publish job attempted to upload 1.0.1 https://github.com/litestar-org/fast-query-parsers/actions/runs/5611116044/jobs/10267115552

there is no 1.0.2 on pypi

@provinzkraut
Copy link
Member Author

Yeah, that should have failed 🤷
Fixed it now (=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants