Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement(Infra): Docs preview link in first message #3304

Open
JacobCoffee opened this issue Apr 2, 2024 · 2 comments
Open

Enhancement(Infra): Docs preview link in first message #3304

JacobCoffee opened this issue Apr 2, 2024 · 2 comments
Labels
CI This is CI related Documentation 📚 This is related to documentation Enhancement This is a new feature or request Good First Issue This is good for newcomers to take on Help Wanted 🆘 This is good for people to work on Infrastructure This is Infrastructure related

Comments

@JacobCoffee
Copy link
Member

JacobCoffee commented Apr 2, 2024 •
edited by polar-sh bot

Summary

Instead of searching through a sea of commits, comments, and bots posting in the pull request thread preferably we would just edit the message in place with a link and a new section.

Basic Example

See: python/devguide#1300

Drawbacks and Impact

No response

Unresolved questions

No response

Note

While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.

Check out all issues funded or available for funding on our Polar.sh dashboard

  • If you would like to see an issue prioritized, make a pledge towards it!
  • We receive the pledge once the issue is completed & verified
  • This, along with engagement in the community, helps us know which features are a priority to our users.
Fund with Polar
@JacobCoffee JacobCoffee added Documentation 📚 This is related to documentation Enhancement This is a new feature or request Help Wanted 🆘 This is good for people to work on Good First Issue This is good for newcomers to take on Infrastructure This is Infrastructure related CI This is CI related labels Apr 2, 2024
@JacobCoffee
Copy link
Member Author

It would also be helpful to display some kind of banner that you are browsing a PR version of the docs with a mention of the branch name or pr title or something

@hugovk
Copy link
Contributor

hugovk commented Apr 2, 2024

See: python/devguide#1300

This is added by GitHub Actions:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI This is CI related Documentation 📚 This is related to documentation Enhancement This is a new feature or request Good First Issue This is good for newcomers to take on Help Wanted 🆘 This is good for people to work on Infrastructure This is Infrastructure related
Projects
Overview
Status: Triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hugovk @JacobCoffee