Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document style on naming env vars #1300

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Mar 25, 2024

Fixes #1285.

I wasn't sure where to put it, so went for developer-workflow/stdlib.html.

Is there a better place?


馃摎 Documentation preview 馃摎: https://cpython-devguide--1300.org.readthedocs.build/

@hugovk hugovk added the guide-new content Additions; New content or section needed label Mar 25, 2024
@hugovk hugovk mentioned this pull request Mar 25, 2024
developer-workflow/stdlib.rst Outdated Show resolved Hide resolved
developer-workflow/stdlib.rst Outdated Show resolved Hide resolved
developer-workflow/stdlib.rst Outdated Show resolved Hide resolved
developer-workflow/stdlib.rst Show resolved Hide resolved
@ezio-melotti
Copy link
Member

After reviewing the rest of the page, I think this new section should also cover when is it ok to add new envvars and how to do it, even though you might want to do that in a separate PR.

hugovk and others added 2 commits March 26, 2024 14:12
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
developer-workflow/stdlib.rst Outdated Show resolved Hide resolved
@hugovk hugovk merged commit 9f77765 into python:main Apr 2, 2024
4 checks passed
@hugovk hugovk deleted the document-env-var-style branch April 2, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guide-new content Additions; New content or section needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document env var style
4 participants