-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Remove use of assert
for pydantic import flow control
#3354
Labels
area/contrib
This PR involves changes to the contrib (Deprecated)
Bug 🐛
This is something that is not working as expected
Good First Issue
This is good for newcomers to take on
Help Wanted 🆘
This is good for people to work on
Comments
Why not just raise an |
Yeah |
This issue has been closed in #3359. The change will be included in the upcoming patch release. |
A fix for this issue has been released in v2.8.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/contrib
This PR involves changes to the contrib (Deprecated)
Bug 🐛
This is something that is not working as expected
Good First Issue
This is good for newcomers to take on
Help Wanted 🆘
This is good for people to work on
Description
It was a poor choice to use assertions for the Pydantic import version discrimination refactor in #3347, as they can be optimized away.
We should revert to raising some other exception type where this was applied.
litestar/litestar/contrib/pydantic/pydantic_dto_factory.py
Lines 26 to 37 in fe73848
URL to code causing the issue
No response
MCVE
# Your MCVE code here
Steps to reproduce
Screenshots
"![SCREENSHOT_DESCRIPTION](SCREENSHOT_LINK.png)"
Logs
No response
Litestar Version
v2.8.2
Platform
Note
While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.
Check out all issues funded or available for funding on our Polar.sh dashboard
The text was updated successfully, but these errors were encountered: