Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed middleware call order #105

Merged
merged 5 commits into from
Apr 25, 2022

Conversation

slavugan
Copy link
Contributor

Currently middlewares provided by user are called in reverse order, my changes make them to be called in order provided by user.
Also changed addition of TrustedHostMiddleware and CORSMiddleware so that they called before custom middlewares.

Copy link
Contributor

@Goldziher Goldziher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😃. Please fix tests.

starlite/app.py Outdated Show resolved Hide resolved
starlite/app.py Outdated Show resolved Hide resolved
starlite/app.py Outdated Show resolved Hide resolved
@Goldziher Goldziher merged commit 2fd16a5 into litestar-org:main Apr 25, 2022
@slavugan slavugan deleted the middleware_call_order branch April 25, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants