Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace pydantic models with dataclasses #1242

Merged
merged 5 commits into from Feb 27, 2023
Merged

replace pydantic models with dataclasses #1242

merged 5 commits into from Feb 27, 2023

Conversation

Goldziher
Copy link
Contributor

PR Checklist

  • Have you followed the guidelines in CONTRIBUTING.rst?
  • Have you got 100% test coverage on new code?
  • Have you updated the prose documentation?
  • Have you updated the reference documentation?

@Goldziher Goldziher requested a review from a team as a code owner February 25, 2023 15:00
@Goldziher Goldziher linked an issue Feb 25, 2023 that may be closed by this pull request
StaticFilesConfig and virtual directories #1234
Closed
@Goldziher Goldziher force-pushed the 1234-staticfilesconfig-and-virtual-directories branch from 80b6bad to 2d23071 Compare February 25, 2023 15:35
@Goldziher Goldziher mentioned this pull request Feb 25, 2023
Closed
@Goldziher Goldziher force-pushed the 1234-staticfilesconfig-and-virtual-directories branch 2 times, most recently from 6b529aa to 11f2ebe Compare February 25, 2023 16:23
@Goldziher Goldziher force-pushed the 1234-staticfilesconfig-and-virtual-directories branch 4 times, most recently from 7a83639 to 2a618b8 Compare February 26, 2023 20:26
@Goldziher Goldziher force-pushed the 1234-staticfilesconfig-and-virtual-directories branch from 2a618b8 to 6ce1f79 Compare February 26, 2023 20:35
@sonarcloud
Copy link

sonarcloud bot commented Feb 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

99.9% 99.9% Coverage
0.0% 0.0% Duplication

peterschutt
peterschutt approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@peterschutt peterschutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@peterschutt peterschutt merged commit 5b1a3c2 into main Feb 27, 2023
@peterschutt peterschutt deleted the 1234-staticfilesconfig-and-virtual-directories branch February 27, 2023 11:14
@NomAnor NomAnor mentioned this pull request Mar 21, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterschutt peterschutt peterschutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StaticFilesConfig and virtual directories
2 participants
@Goldziher @peterschutt