Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): typo in core Starlite app #1288

Merged
merged 1 commit into from Mar 6, 2023
Merged

fix(docs): typo in core Starlite app #1288

merged 1 commit into from Mar 6, 2023

Conversation

JacobCoffee
Copy link
Member

PR Checklist

  • Have you followed the guidelines in CONTRIBUTING.rst?
  • Have you got 100% test coverage on new code?
  • Have you updated the prose documentation?
  • Have you updated the reference documentation?

Fixes a typo startlite in the core Starlite application from_config class method.

Resolves #1287

@JacobCoffee JacobCoffee added the Documentation 📚 This is related to documentation label Mar 5, 2023
@JacobCoffee JacobCoffee requested a review from a team as a code owner March 5, 2023 22:48
@JacobCoffee JacobCoffee self-assigned this Mar 5, 2023
@JacobCoffee
Copy link
Member Author

Tests will probably fail, the last 2 merges have also failed due to codeQL for some reason?

@JacobCoffee
Copy link
Member Author

Welll. I lied. :)

@JacobCoffee JacobCoffee closed this Mar 5, 2023
@JacobCoffee JacobCoffee deleted the fix_from_config_typo(#1287) branch March 5, 2023 22:53
@peterschutt
Copy link
Contributor

maybe those other failures were b/c we were on the 1.x branch

@JacobCoffee JacobCoffee restored the fix_from_config_typo(#1287) branch March 6, 2023 00:23
@JacobCoffee JacobCoffee reopened this Mar 6, 2023
@JacobCoffee JacobCoffee merged commit 94e1ee7 into litestar-org:main Mar 6, 2023
@JacobCoffee JacobCoffee deleted the fix_from_config_typo(#1287) branch March 6, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterschutt peterschutt peterschutt approved these changes

Assignees

@JacobCoffee JacobCoffee

Labels
Documentation 📚 This is related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix typo in from_config class method
2 participants
@JacobCoffee @peterschutt