Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the typing for url_for kwargs unpack #1610

Merged
merged 1 commit into from May 3, 2023

Conversation

whiskeyriver
Copy link
Contributor

The url_for function types its kwargs unpack using the container type of dict[str, Any]. This should just use Any.

Pull Request Checklist

  • [N/A] New code has 100% test coverage
  • [N/A] (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • [N/A] (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

By submitting this issue, you agree to:

Description

Lint fails this function call when using keyword args:
dict_str_any

Close Issue(s)

The `url_for` function types its kwargs unpack using the container type
of `dict[str, Any]`. This should just use `Any`.
@whiskeyriver whiskeyriver requested a review from a team as a code owner May 3, 2023 04:59
@peterschutt
Copy link
Contributor

Thanks @whiskeyriver!

@all-contributors please add @whiskeyriver for code

@allcontributors
Copy link
Contributor

@peterschutt

I've put up a pull request to add @whiskeyriver! 🎉

@peterschutt peterschutt merged commit 3fd6dcb into litestar-org:main May 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants