Enhancement: Trio compatible event-emitters #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provinzkraut
changed the title
provinzkraut
force-pushed
the
events-anyio-compatible
branch
from
5edd11b
to
63cc9a4
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Goldziher
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduced in #1635 allow a refactoring of event emitters to be trio-compatible, by removing
asyncio.Taskandasyncio.Queueand replacing them with task groups and streams.Additional changes:
BaseEventEmitterBackendnow inherits fromAbstractAsyncContextManagerto make use of the lifespan context manager. Theon_startupandon_shutdownmethods have been subsequently removed.