Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: duckdb and Google spanner support. #1744

Merged
merged 35 commits into from Jun 3, 2023
Merged

feat: duckdb and Google spanner support. #1744

merged 35 commits into from Jun 3, 2023

Conversation

cofin
Copy link
Member

@cofin cofin commented May 26, 2023 •
edited

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description

This PR should implement test cases and adjustments to support duckdb and spanner.

  • Full set of test cases for BigInt and UUID primary key backends
  • BigIntIdentity was modified to use Sequences instead of Identity to ensure compatibility with all engines (including duckdb)
  • JSON type now implements the correct JSON check constraint for oracle
  • _sentinel column is only added to tables with a UUID primary key
  • Modified the behavior of update to account for an edge case where you are updating a model with lazy loaded child attributes, the get call within update would cause issues with the new attributes.
  • Additional test cases for get_or_create upsert
  • Spanner will not not support BigIntIdentity. Spanner should not use monotonically incrementing/decrementing values as primary keys.

Close Issue(s)

@cofin cofin changed the title feat: implement basic structure for duckdb and spanner support feat: repository tutorial, duckdb and Google spanner support. May 28, 2023
@cofin cofin mentioned this pull request May 29, 2023
Closed
@cofin
Copy link
Member Author

cofin commented May 29, 2023 •
edited

Issue and patch opened in the Spanner repository: googleapis/python-spanner-sqlalchemy#325

@cofin cofin marked this pull request as ready for review June 2, 2023 17:51
@cofin cofin requested a review from a team as a code owner June 2, 2023 17:51
@cofin
Copy link
Member Author

cofin commented Jun 2, 2023

Splitting the tutorial into a new PR

@cofin cofin changed the title feat: repository tutorial, duckdb and Google spanner support. feat: duckdb and Google spanner support. Jun 2, 2023
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/1744

peterschutt
peterschutt approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@peterschutt peterschutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @cofin

@cofin cofin merged commit aa626eb into litestar-org:main Jun 3, 2023
11 checks passed
@cofin cofin deleted the spanner branch June 3, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterschutt peterschutt peterschutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cofin @peterschutt