Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Internal Server Error detail #1857

Merged
merged 1 commit into from Jun 21, 2023
Merged

Fix: Internal Server Error detail #1857

merged 1 commit into from Jun 21, 2023

Conversation

peterschutt
Copy link
Contributor

Always use "Internal Server Error" as default detail for 500 errors so that our default behavior limits leaking implementation detail.

Closes #1856

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description

Close Issue(s)

Always use "Internal Server Error" as default detail for 500 errors so that our default behavior limits leaking implementation detail.
@peterschutt peterschutt requested a review from a team as a code owner June 21, 2023 09:03
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/1857

@peterschutt peterschutt merged commit a8498fd into main Jun 21, 2023
13 checks passed
@peterschutt peterschutt deleted the 500-response-detail branch June 21, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: don't leak implementation detail on 500s
2 participants