Replace Headers with Dataclasses #1917
Conversation
| Union, | ||
| cast, | ||
| get_args, |
There was a problem hiding this comment.
use the version from typing_extensions for the helpers because these act differently in older py versions
| @@ -272,7 +271,33 @@ def to_header(self, include_header_name: bool = False) -> str: | |||
|
|
|||
| return (f"{self.HEADER_NAME}: " if include_header_name else "") + self._get_header_value() | |||
|
|
|||
|
|
|||
| def dict( | |||
There was a problem hiding this comment.
so, i dont see why we will need to replicate the pydantic signature here. Do we actually use exclude_unset, exclude_empty etc? Also, since we actually use this stuff internally - we do not need a generalized use here, but only what we actually use.
| @@ -352,14 +384,70 @@ def prevent_storing(cls) -> "CacheControlHeader": | |||
|
|
|||
| return cls(no_store=True) | |||
|
|
|||
| @classmethod | |||
| def _get_type_annotations(cls) -> Dict[str, Type]: | |||
There was a problem hiding this comment.
so, i think you are reinventing the wheel here. Please rebase on main and than use the logic inside litestar.typing to handle this kind of stuff. There is a class there called FieldDefinition and it is used throughout the codebase to parse types.
| return cls._type_annotations | ||
|
|
||
| @classmethod | ||
| def _convert_to_type(cls, value: str, expected_type: Type) -> Any: |
| def test_etag_documentation_only() -> None: | ||
| assert ETag(documentation_only=True).value is None | ||
|
|
||
|
|
||
| def test_etag_no_value() -> None: | ||
| with pytest.raises(ValidationError): | ||
| with pytest.raises(ValueError): |
There was a problem hiding this comment.
please raise our ValidationException class
|
@Tsdevendra1 can you update the PR with the changes? I would like to get it merged this weekend if possible |
|
well, actually i need this now - so i will merge it. @all-contributors add @Tsdevendra1 code |
|
I've put up a pull request to add @Tsdevendra1! 🎉 |
Pull Request Checklist
Description
Currently there are some left over pydantic models in the datastructure.headers namespace. This PR replaces them with dataclasses.
Close Issue(s)
Closes #1386