Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added path name in ImproperlyConfiguredException in case of missing param type #1935

Merged
merged 1 commit into from Jul 11, 2023

Conversation

euri10
Copy link
Contributor

@euri10 euri10 commented Jul 11, 2023

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description

This PR adds the path name in case the param type is missing, it's easier to identify the culprit if you're doing this error

@euri10 euri10 requested a review from a team as a code owner July 11, 2023 13:14
@euri10
Copy link
Contributor Author

euri10 commented Jul 11, 2023

I'd be happy to get a hint on fixing the mypy erro, seems unrelated to me but I dont know the code base well enough

@Goldziher
Copy link
Contributor

@all-contributors add @euri10 code

@allcontributors
Copy link
Contributor

@Goldziher

I've put up a pull request to add @euri10! 🎉

@Goldziher Goldziher merged commit a1f4768 into litestar-org:main Jul 11, 2023
10 of 11 checks passed
@euri10 euri10 deleted the better_invalid_path_param_error branch July 11, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants