Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add SSE support #2035

Merged
merged 1 commit into from Jul 21, 2023
Merged

feat: add SSE support #2035

merged 1 commit into from Jul 21, 2023

Conversation

Goldziher
Copy link
Contributor

This PR adds SSE (Server Sent Event) support, closing #1185

@Goldziher Goldziher requested a review from a team as a code owner July 21, 2023 20:47
@Goldziher Goldziher requested a review from a team July 21, 2023 20:48
cofin
cofin approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I actually expected it to be a bit more complicated than this.

@Goldziher Goldziher merged commit 73d913a into main Jul 21, 2023
11 of 13 checks passed
@Goldziher Goldziher deleted the sse branch July 21, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofin cofin cofin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Goldziher @cofin