Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema): support configuring operation_id_creator on the route h… #2078

Conversation

Goldziher
Copy link
Contributor

This PR allows operation_id on route handlers to be a callable. Previously we supported this only on the global open api configuration, but it also makes sense to allow this to be locally overriden.

@Goldziher Goldziher requested review from a team as code owners July 27, 2023 18:16
@Goldziher Goldziher linked an issue Jul 27, 2023 that may be closed by this pull request
4 tasks
Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Goldziher Goldziher merged commit 21a1f44 into main Jul 27, 2023
13 checks passed
@Goldziher Goldziher deleted the 2075-bug-operation_id-cannot-be-set-if-a-handler-has-multiple-paths-defined branch July 27, 2023 18:21
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: operation_id cannot be set if a handler has multiple paths defined
3 participants