Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moved application/octet-stream from contentEncoding to contentMediaType #2130

Conversation

Goldziher
Copy link
Contributor

This PR fixes a bug in the response schema where contentEncoding had a default of application/octet-stream, which actually should be the default of contentMediaType.

@Goldziher Goldziher force-pushed the 2062-bug-content_encoding-incorrectly-defaults-to-applicationoctet-stream-for-openapi-specs-of-file-and-stream-responses branch from b6869fb to d7df16a Compare August 6, 2023 17:00
@sonarcloud
Copy link

sonarcloud bot commented Aug 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Aug 6, 2023

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2130

Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofin cofin merged commit fbfe60f into main Aug 6, 2023
19 checks passed
@cofin cofin deleted the 2062-bug-content_encoding-incorrectly-defaults-to-applicationoctet-stream-for-openapi-specs-of-file-and-stream-responses branch August 6, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants