fix: DTOData bug with renamed fields #2144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Implementing a fix for
DTOData
#2065 introduced a new bug. Originally, fields passed toDTOData.create_instance
were handled using their serialized names. For example, when using camel case for an excluded fieldentity_id
,data.create_instance(entityId="1")
would work butdata.create_instance(entity_id="A")
wouldn't. That was not ideal so the erroneous fix was to ignore serialized field names altogether when dealing withDTOData
. Here is an example of why this would fail:Since. #2065 ignored serialized names, the above example will fail to deserialize
b'{firstName: "J"}'
. The fix: only override serialization names when usingdata.create_instance
, otherwise, when dealing withDTOData
we should use the serialization name (to successfully deserialize)Close Issue(s)