fix: add default receive and send parameter values for HTMXRequest #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2145 |
tompin82
changed the title
|
@all-contirbutors add @tompin82 for code and bugs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there seemed to be an issue setting the apps
request_classtoHTMXRequest.The CSRF middleware doesn't initialize the
request_classwith asendargument, which causes theHTMXRequestclass to fail its initialization since it expectssendto exist.This PR simply adds the
empty_receiveandempty_sendfunctions as default vaules, which is consistent with the signature in the request class it derives from.