feat: exclude implicit fields for sqlalchemy dto #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alc-Alc
reviewed
Aug 17, 2023
|
@abdulhaq-e Please change the target branch to |
abdulhaq-e
force-pushed
the
skip_implicit_fields
branch
from
02e95a5
to
0cb1251
Compare
Done. |
provinzkraut
requested changes
Aug 19, 2023
|
@cofin can you take a look at this one as well? |
provinzkraut
force-pushed
the
v2.1
branch
2 times, most recently
from
2b260c2
to
6d77c51
Compare
This one is now resolved. The fix is waiting to merge into |
provinzkraut
force-pushed
the
skip_implicit_fields
branch
from
8664aa2
to
f526aae
Compare
provinzkraut
requested changes
Aug 21, 2023
abdulhaq-e
force-pushed
the
skip_implicit_fields
branch
from
3ad15b7
to
19c1dfc
Compare
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2170 |
abdulhaq-e
force-pushed
the
skip_implicit_fields
branch
from
7bc2a6e
to
ae092ec
Compare
use separate sqlalchemy dto config support Annotated allow overrides for hybrid properties and non-private Mark fields Apply suggestions from code review Update litestar/contrib/sqlalchemy/dto.py Co-authored-by: Alc-Alc <45509143+Alc-Alc@users.noreply.github.com> pythonic findWhere docs update use subclass implementation typo update lock file use poetry.lock from main Switch to private methods
abdulhaq-e
force-pushed
the
skip_implicit_fields
branch
from
ae092ec
to
766ad31
Compare
Goldziher
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
SQLAlchemyDTOcan now be configured using a separate config object. This can be set using both class inheritance andAnnotated:or
The new configuration currently accepts a single attribute which is
include_implicit_fieldsthat has a default value ofTrue. If set to toFalse, all implicitly mapped columns will be hidden from theDTO. If set to"hybrid-only", then hybrid properties will be shown but not other implicit columns. Finally, implicit columns that are marked withMark.READ_ONLYorMark.WRITE_ONLYwill always be shown regardless of the value ofinclude_implicit_fields.Close Issue(s)