Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth-middleware): don't auth OPTIONS and HEAD requests for SessionAuth middlerware #2182

Merged
merged 6 commits into from Aug 20, 2023
Merged

feat(auth-middleware): don't auth OPTIONS and HEAD requests for SessionAuth middlerware #2182

merged 6 commits into from Aug 20, 2023

Conversation

Mattwmaster58
Copy link
Contributor

@Mattwmaster58 Mattwmaster58 commented Aug 19, 2023 •
edited

this breaks browser preflights on authenticated endpoints

Pull Request Checklist

  • x New code has 100% test coverage
  • x (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • x (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description

Follow up on #2160 which didn't address SessionAuth middleware.

Close Issue(s)

@Mattwmaster58
fix: don't auth OPTIONS and HEAD requests for SessionAuth middlerware
cd6b10a 
this breaks browser preflights on authenticated endpoints
@Mattwmaster58 Mattwmaster58 changed the title feat(auth-middleware) don't auth OPTIONS and HEAD requests for SessionAuth middlerware feat(auth-middleware): don't auth OPTIONS and HEAD requests for SessionAuth middlerware Aug 19, 2023
@Mattwmaster58 Mattwmaster58 marked this pull request as ready for review August 19, 2023 23:30
@Mattwmaster58 Mattwmaster58 requested review from a team as code owners August 19, 2023 23:30
@Mattwmaster58
Copy link
Contributor Author

there were some mypy issues, but most seemed unrelated to my code

cofin
cofin approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll see if we can get these other errors cleaned up.

provinzkraut and others added 2 commits August 20, 2023 09:22
@provinzkraut
Apply suggestions from code review
34d4caa
@provinzkraut
fix: typing
7ac918a 
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
@provinzkraut provinzkraut merged commit 1b0fdd4 into litestar-org:main Aug 20, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provinzkraut provinzkraut provinzkraut requested changes

@cofin cofin cofin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: regression v2.0.0beta4 -> main@HEAD
3 participants
@Mattwmaster58 @cofin @provinzkraut