New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: `SQLAlchemyPlugin` refactored. #2269

Merged

cofin merged 7 commits into main from sqlalchemy-plugin-init

Sep 1, 2023

Member

cofin commented Sep 1, 2023 •

edited

Pull Request Checklist

New code has 100% test coverage
(If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
(If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description

This PR changes the way the SQLAlchemyPlugin works. It will now append the other plugins instead of the inheritance that was previously used. This makes using the plugins.get function work as expected.

Close Issue(s)


          fix: set SQLAlchemyPlugin to add other plugins, instead of inheriting.

c5b29b7

cofin requested review from a team as code owners

September 1, 2023 18:35

cofin changed the title ~~fix: set SQLAlchemyPlugin to add other plugins, instead of inheriting.~~ fix: SQLAlchemyPlugin refactored.


          fix: linting

14b3ed7

Alc-Alc approved these changes

View reviewed changes

cofin added 2 commits

September 1, 2023 18:50


          fix: update pre-commit

219d551


          fix: call super.__init__

d800242

provinzkraut approved these changes

View reviewed changes

Member

provinzkraut left a comment

Yes, this is way better!

cofin and others added 3 commits

September 1, 2023 19:00


          fix: revert change

f1d180a


          Update .pre-commit-config.yaml

fbba13f


          Update poetry.lock

1e9b2a8

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

github-actions bot commented Sep 1, 2023

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2269

cofin merged commit cd07fd7 into main

19 checks passed

cofin deleted the sqlalchemy-plugin-init branch

September 1, 2023 19:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment