Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sqla-repository): swap to the advanced_alchemy implementations #2312

Merged
merged 25 commits into from
Sep 18, 2023

Conversation

cofin
Copy link
Member

@cofin cofin commented Sep 17, 2023

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description

  • This PR swaps the repository to the advanced_alchemy implementations

Close Issue(s)

@cofin cofin requested review from a team as code owners September 17, 2023 20:10
@cofin cofin changed the title Advanced_alchemy feat(sqla-repository): swap to the advanced_alchemy implementations Sep 17, 2023
@JacobCoffee
Copy link
Member

Trying to check out the docs issue but I keep failing on random points :(
Idk whats wrong

reading sources... [ 96%] usage/routing/handlers .. usage/security/index
Sphinx parallel build error:
tools.sphinx_ext.run_examples.StartupError: App docs/examples/parameters/query_params.py failed to come online
Command exited with exit code: 2
The server will continue serving the build folder, but the contents being served are no longer in sync with the documentation sources. Please fix the cause of the error above or press Ctrl+C to stop the server.
/home/coffeej/git/python/litestar-org/litestar/.venv/lib/python3.11/site-packages/sphinx/util/inspect.py:376: SAWarning: Unmanaged access of declarative attribute _sentinel from non-mapped class UUIDPrimaryKey
  return getattr(obj, name, *defargs)
ERROR: Example: docs/examples/lifecycle_hooks/before_request.py:['curl', '-s', 'http://127.0.0.1:9000/?name=Luke'] yielded no results
ERROR: Example: docs/examples/lifecycle_hooks/before_request.py:['curl', '-s', 'http://127.0.0.1:9000/?name=Ben'] yielded no results

Sphinx parallel build error:
tools.sphinx_ext.run_examples.StartupError: App docs/examples/responses/response_content.py failed to come online
Command exited with exit code: 2
The server will continue serving the build folder, but the contents being served are no longer in sync with the documentation sources. Please fix the cause of the error above or press Ctrl+C to stop the server.
[I 230917 20:39:24 server:335] Serving on http://127.0.0.1:8000
[I 230917 20:39:24 handlers:62] Start watching changes
[I 230917 20:39:24 handlers:64] Start detecting changes
^C[I 230917 20:39:31 server:358] Shutting down...
reading sources... [ 92%] usage/middleware/creating-middleware .. usage/responses
Sphinx parallel build error:
tools.sphinx_ext.run_examples.StartupError: App docs/examples/data_transfer_objects/factory/marking_fields.py failed to come online
Command exited with exit code: 2
The server will continue serving the build folder, but the contents being served are no longer in sync with the documentation sources. Please fix the cause of the error above or press Ctrl+C to stop the server.

@JacobCoffee
Copy link
Member

Got it building, but I am going to guess a lot of these issues come from @jolt-org/advanced-alchemy doc issues.. @provinzkraut?

litestar/contrib/sqlalchemy/repository/types.py Outdated Show resolved Hide resolved
litestar/dto/config.py Show resolved Hide resolved
@provinzkraut
Copy link
Member

Got it building, but I am going to guess a lot of these issues come from @jolt-org/advanced-alchemy doc issues.. @provinzkraut?

Yeah, we'll need to get those docs published before that will work.

@cofin cofin enabled auto-merge (squash) September 18, 2023 18:40
@cofin cofin disabled auto-merge September 18, 2023 18:44
@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2312

@cofin cofin merged commit 7ed396e into litestar-org:main Sep 18, 2023
16 checks passed
@cofin cofin deleted the advanced_alchemy branch September 18, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants